Skip to content

#40079 SwiftOtter-SOP-348 Resolve issues with Product listing with negative … #40080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: 2.4-develop
Choose a base branch
from
Open

#40079 SwiftOtter-SOP-348 Resolve issues with Product listing with negative … #40080

wants to merge 20 commits into from

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

PR addresses the negative ?p= value in the Category pagination, that currently results in exception and is considered a valid request.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Negative ?p= query string causes ElasticSearch exception #40079

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 18, 2025

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 21, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 21, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review July 25, 2025 06:56
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Jul 25, 2025
engcom-Hotel
engcom-Hotel requested changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lbajsarowicz,

Thanks for the contribution!

The fix seems good to us, but the fix is only focuses on the product listing page, it would be good if we can implement it for the search page and other product listing page as well.

Also please add some automated test in accordance to the DOD and fix the failed static test failure.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Jul 25, 2025
@engcom-Dash engcom-Dash self-assigned this Aug 1, 2025
@lbajsarowicz lbajsarowicz force-pushed the 2.4-develop-pagination-fix branch from fae6cc1 to d956c24 Compare August 3, 2025 21:38
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

I must express my deep love to MFTF in a current form, where things definitely do not work as anticipated and scope of variable availability is a pure pain.

@lbajsarowicz
Copy link
Contributor Author

@magento run all test

It turns out that you can't use variables {{}} in regex="" to refer to Page Object.

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Just try again @magento-automated-testing

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash engcom-Dash force-pushed the 2.4-develop-pagination-fix branch from 58e72a5 to 79c384a Compare September 18, 2025 12:23
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash engcom-Dash force-pushed the 2.4-develop-pagination-fix branch from 79c384a to 7deab80 Compare September 18, 2025 13:43
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests

@engcom-Dash engcom-Dash force-pushed the 2.4-develop-pagination-fix branch from 7deab80 to 9aa6ae0 Compare September 24, 2025 10:51
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@engcom-Hotel, the Static Check and Integration Check failures have been fixed. Kindly please review this PR so we can move forward.

@engcom-Dash engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard Sep 24, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Sep 24, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Sep 25, 2025
@engcom-Bravo
Copy link
Contributor

Hi @lbajsarowicz,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenarios

Before: ✖️

Screenshot 2025-09-26 at 12 21 26 pm

After: ✔️

  • System redirects to 1st page of results
  • No logs in Exeception.log

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Extended testing (optional) in Community Dashboard Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Dash engcom-Dash

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Extended testing (optional)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative ?p= query string causes ElasticSearch exception
5 participants
@lbajsarowicz @engcom-Hotel @engcom-Dash @engcom-Bravo @engcom-Charlie